Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed NewReleaseNotification couldn't be hidden/disabled #374

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: fixed NewReleaseNotification couldn't be hidden/disabled #374

merged 1 commit into from
Oct 12, 2022

Conversation

ShootingKing-AM
Copy link
Contributor

  • Typo is settingStore data name
  • component NewReleaseNotification cannot be permanently disabled or hidden since state data is not in sync with settingStore's state

aw-webui/src/stores/settings.ts

Lines 43 to 49 in 1980a40

newReleaseCheckData: {
isEnabled: true,
nextCheckTime: moment().add(SHORT_BACKOFF_PERIOD, 'seconds'),
howOftenToCheck: SHORT_BACKOFF_PERIOD,
timesChecked: 0,
},

aw-webui/src/components/NewReleaseNotification.vue

Lines 42 to 44 in 1980a40

computed: {
...mapWritableState(useSettingsStore, { data: 'newReleaseNotification' }),
},

1
2

@ShootingKing-AM
fix: NewReleaseNotification cannot be hidden/disabled
8be675b 
- Typo is settingStore data name
- component NewReleaseNotification cannot be permanently disabled or hidden since state data is not in sync with settingStore's state
@ErikBjare ErikBjare changed the title fix: NewReleaseNotification cannot be hidden/disabled fix: fixed NewReleaseNotification couldn't be hidden/disabled Oct 12, 2022
@ErikBjare ErikBjare merged commit bfe847c into ActivityWatch:master Oct 12, 2022
@ErikBjare
Copy link
Member

Thanks for this @ShootingKing-AM! ❤️

@ShootingKing-AM ShootingKing-AM deleted the fix-rlse-notification branch October 12, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShootingKing-AM @ErikBjare